-
Notifications
You must be signed in to change notification settings - Fork 3
Improve Navigator (Feature Complete for First Release) #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Missing things:
|
kyanvde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all looks good, couple small things that aren't really necessary but could be nice. There is one TO-DO you left behind though that might be important.
src/main/java/net/buildtheearth/modules/navigation/components/warps/WarpsComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/buildtheearth/modules/navigation/components/warps/menu/WarpGroupEditMenu.java
Show resolved
Hide resolved
src/main/java/net/buildtheearth/modules/navigation/components/warps/menu/WarpGroupMenu.java
Outdated
Show resolved
Hide resolved
|
Does this PR also close #35 ? Else that might be a nice thing to fix. |
Not yet, also i think it's also fine to do it outside of it. |
kyanvde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, note that I have not tested anything ingame.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements feature completeness for the Navigator, expanding its functionality with new configuration options, improved menu handling, better server switching capabilities, and enhanced user experience features. It adds support for multiple build team server types and introduces new navigation utilities.
Key changes include:
- Configuration updates with new navigation items (plotsystem, explore) and warp sorting options
- Enhanced server switching with transfer capabilities and improved error handling
- New BuildTeam command for direct team navigation with tab completion
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/plugin.yml | Updates command structure and adds new buildteam command with aliases |
| src/main/resources/modules/navigation/config.yml | Adds new navigation items and warp sorting configuration |
| src/main/java/net/buildtheearth/utils/io/ConfigPaths.java | Defines config paths for new navigation features |
| src/main/java/net/buildtheearth/utils/Utils.java | Removes unused methods and fixes boolean operators |
| src/main/java/net/buildtheearth/utils/ChatHelper.java | Adds error logging method with exception parameter |
| src/main/java/net/buildtheearth/modules/network/ | Network model updates, API improvements, and transfer support |
| src/main/java/net/buildtheearth/modules/navigation/ | Major navigation enhancements including new utilities, menu improvements, and warp functionality |
| src/main/java/net/buildtheearth/modules/generator/ | Minor command structure improvements |
| src/main/java/net/buildtheearth/modules/common/ | Command registration updates and module handling improvements |
| pom.xml | Dependency version updates for XSeries and AnvilGUI |
| README.md | Documentation updates with new wiki links and contributor additions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/java/net/buildtheearth/modules/navigation/components/tpll/TpllComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/buildtheearth/modules/navigation/components/tpll/TpllComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/buildtheearth/modules/network/api/NetworkAPI.java
Outdated
Show resolved
Hide resolved
src/main/java/net/buildtheearth/modules/navigation/NavUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/buildtheearth/modules/navigation/components/tpll/TpllComponent.java
Show resolved
Hide resolved
src/main/java/net/buildtheearth/modules/navigation/menu/CountrySelectorMenu.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
The canvas lib update was required to fix a menu bug, where sometimes the listener wasn't working. In the plugin.yml PlotSystem-Terra was added as a soft-depend, so our detection can reliabel work. Added myself as an author. Updated the Readme to reflect the current state.
It's only a short-term solution. Long term we should use smt local because of speed & rate limits. Nominatim just blocked my server :c.
…andling - Improved the CountrySelectorMenu for better usability and performance - Enhanced click handlers for countries: - Connected build teams allow direct player transfer to server - Optimized IP and port extraction using indexOf and substring - Added appropriate messages for missing connections or IPs - Improved area number formatting with dot notation for thousands separators - Added debug logging to track clicks and menu actions - Adjusted menu masking for consistent layout These changes improve navigation flow, visual clarity, and system stability while providing a better player experience when exploring different regions.
Otherwise it will not work & paper will throw a exception that i only can be opened on main thread.
So you can test api related things more easily.
…ce BuildTeam model
…ion - fixes slots in warp group
…and enhance permissions handling
…st and adding nullability annotations
…e warp menu access
0667153 to
dfe4e24
Compare
|
When you click "Back" in the Warp Group Menu it doesnt work Navigator > Explore R > Continent > Country R > Back |
… back menu navigation
# Conflicts: # src/main/resources/plugin.yml
Closes #37.