Skip to content

Conversation

@Zoriot
Copy link
Contributor

@Zoriot Zoriot commented Sep 8, 2025

Closes #37.

@Zoriot
Copy link
Contributor Author

Zoriot commented Sep 8, 2025

Missing things:

  • Test everything
  • Update documentation
  • (Optional) Better Player Connection Failure (Server Switch, Warp, Tpll) handling
  • (Optional) Warp Tags
  • Fix that the Warp right click menu is displayed for Oceania even they have no warps -> Other Warp Group should only be added if there are other warps.

kyanvde
kyanvde previously approved these changes Sep 11, 2025
Copy link
Contributor

@kyanvde kyanvde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all looks good, couple small things that aren't really necessary but could be nice. There is one TO-DO you left behind though that might be important.

@kyanvde
Copy link
Contributor

kyanvde commented Sep 11, 2025

Does this PR also close #35 ? Else that might be a nice thing to fix.

@Zoriot
Copy link
Contributor Author

Zoriot commented Sep 12, 2025

Does this PR also close #35 ? Else that might be a nice thing to fix.

Not yet, also i think it's also fine to do it outside of it.

Copy link
Contributor

@kyanvde kyanvde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, note that I have not tested anything ingame.

@Zoriot Zoriot self-assigned this Sep 24, 2025
@Zoriot Zoriot added the enhancement New feature or request label Sep 24, 2025
@Zoriot Zoriot added this to the Release v1.0.0 milestone Sep 24, 2025
@Zoriot Zoriot requested a review from Copilot September 24, 2025 21:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements feature completeness for the Navigator, expanding its functionality with new configuration options, improved menu handling, better server switching capabilities, and enhanced user experience features. It adds support for multiple build team server types and introduces new navigation utilities.

Key changes include:

  • Configuration updates with new navigation items (plotsystem, explore) and warp sorting options
  • Enhanced server switching with transfer capabilities and improved error handling
  • New BuildTeam command for direct team navigation with tab completion

Reviewed Changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/main/resources/plugin.yml Updates command structure and adds new buildteam command with aliases
src/main/resources/modules/navigation/config.yml Adds new navigation items and warp sorting configuration
src/main/java/net/buildtheearth/utils/io/ConfigPaths.java Defines config paths for new navigation features
src/main/java/net/buildtheearth/utils/Utils.java Removes unused methods and fixes boolean operators
src/main/java/net/buildtheearth/utils/ChatHelper.java Adds error logging method with exception parameter
src/main/java/net/buildtheearth/modules/network/ Network model updates, API improvements, and transfer support
src/main/java/net/buildtheearth/modules/navigation/ Major navigation enhancements including new utilities, menu improvements, and warp functionality
src/main/java/net/buildtheearth/modules/generator/ Minor command structure improvements
src/main/java/net/buildtheearth/modules/common/ Command registration updates and module handling improvements
pom.xml Dependency version updates for XSeries and AnvilGUI
README.md Documentation updates with new wiki links and contributor additions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

MineFact
MineFact previously approved these changes Sep 27, 2025
@MineFact

This comment was marked as resolved.

@MineFact

This comment was marked as resolved.

@MineFact

This comment was marked as resolved.

Zoriot added 13 commits October 19, 2025 00:06
The canvas lib update was required to fix a menu bug, where sometimes the listener wasn't working.
In the plugin.yml PlotSystem-Terra was added as a soft-depend, so our detection can reliabel work. Added myself as an author. Updated the Readme to reflect the current state.
It's only a short-term solution. Long term we should use smt local because of speed & rate limits.
Nominatim just blocked my server :c.
…andling

- Improved the CountrySelectorMenu for better usability and performance
- Enhanced click handlers for countries:
  - Connected build teams allow direct player transfer to server
  - Optimized IP and port extraction using indexOf and substring
  - Added appropriate messages for missing connections or IPs
- Improved area number formatting with dot notation for thousands separators
- Added debug logging to track clicks and menu actions
- Adjusted menu masking for consistent layout

These changes improve navigation flow, visual clarity, and system stability
while providing a better player experience when exploring different regions.
Otherwise it will not work & paper will throw a exception that i only can be opened on main thread.
So you can test api related things more easily.
MineFact
MineFact previously approved these changes Oct 30, 2025
@MineFact
Copy link
Member

MineFact commented Oct 30, 2025

When you click "Back" in the Warp Group Menu it doesnt work

Navigator > Explore R > Continent > Country R > Back

@Zoriot Zoriot merged commit 8fae925 into master Nov 8, 2025
1 check passed
@Zoriot Zoriot deleted the improveNavigator branch November 8, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve and finish Sledgehammer Implementation

4 participants